Review Request 122679: Show Desktop feature: refurbished

[Thomas Lübking]

> On März 22, 2015, 8:28 nachm., Kai Uwe Broulik wrote:
> > Sorry for being late to the party:
> > 
> > UX issues I have with that implementation:
> > - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX does it, but that's visuals)
> > - Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - they don't appear in that mode, nor do they exit it
> > - KRunner exits this mode, imho KRunner should be usable from there (usability?)
> > - Panels inaccessible (though usability even proposed hiding them in Dashboard mode, so..)
> > 
> > Other than that this would 100% replace my Dashboard usecase, so +1 for the overall idea.
> > 
> > Usability team, ping?

- No transition
Definitively, but another patch (we'll have to wire up a showingDesktop signal and then script something nicely ;-)

- Cannot access plasmoid or containment config windows
We'll have to require them to either be transient for the desktop or set the keepAbove flag (and interpret that in layers.cpp) to still keep "normal" docks (panels) hidden

- KRunner exits this mode
Afaics that's a general (re-occurring ;-) "problem" w/ krunner, unrelated to this patch.
Non-dock type windows that are not in the desktop group break the mode. This applies because krunner is another process than plasmashell (afair the KDE3 runner was part of kdesktop)
 => KRunner must either become a dock-type (and keepabove or transient) or move itself into the desktops window group (be transient for it or have the same WM_CLIENT_LEADER)
 
However, I put "problem" in quotation marks, because that rather seems the minimize-all (aka. "you wanted to switch the VD" ;-) case of cleaning up the workspace (for the very next action will break the mode anyway when you run a new application)??

- Panels inaccessible
See above - we can either make dock-type windows (mostly panels) unconditionally visible or require them to setup a special condition (transient for desktop or keep above)

The question on what to do here is also the question mostly asked by this RR =)
The global behavior (as long as we don't require transiency/keepabove hints from "some" panels) is very easy to adjust, though.

@Usability team, please also see my very first comment for more information on layer control.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review77926
-----------------------------------------------------------


On Feb. 26, 2015, 1:16 nachm., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 1:16 nachm.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin.
> 
> 
> Bugs: 344083
>     https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
> Author: Thomas Lübking
> Date:   Sun Feb 22 16:41:45 2015 +0100
> 
>     add "MinimizeAll" script
>     
>     to compensate withdrawn core feature (which
>     though has been hidden so far)
> 
> commit 983efb916e282d2263b4abcc92f714c06b3bfcc1
> Author: Thomas Lübking
> Date:   Wed Feb 18 02:09:00 2015 +0100
> 
>     break showingDesktop w/ tabbox/PW/DG
>     
> This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop.
> Also, it makes the tabbox more consistent.
> 
> commit ff531c8e2adc407da00bef88f18d03e3829b25fa
> Author: Thomas Lübking
> Date:   Wed Feb 18 01:37:45 2015 +0100
> 
>     implement showingDesktop by raising the desktop window
> 
> commit 190a0cc022d9935d658a6218d0b3caa79b038563
> Author: Thomas Lübking
> Date:   Wed Feb 18 00:09:46 2015 +0100
> 
>     remove secret showDesktopIsMinimizeAll feature
> 
> 
> Diffs
> -----
> 
>   client.h f064041 
>   client.cpp 3e834f2 
>   effects/desktopgrid/desktopgrid.cpp 97cb2a3 
>   effects/presentwindows/presentwindows.cpp 07660c2 
>   kwin.kcfg 80ca365 
>   tabbox/tabbox.cpp f81a407 
>   scripts/minimizeall/metadata.desktop PRE-CREATION 
>   scripts/minimizeall/contents/code/main.js PRE-CREATION 
>   scripts/CMakeLists.txt 34dedb7 
>   options.cpp cdaa851 
>   options.h 67e5868 
>   layers.cpp 91edc04 
>   manage.cpp f302892 
>   workspace.h 4ecac3d 
>   workspace.cpp 7cbe81e 
> 
> Diff: https://git.reviewboard.kde.org/r/122679/diff/
> 
> 
> Testing
> -------
> 
> * The script (though mostly in KWin4, trouble w/ ksycoca5...)
> * Obviously the supersecret key is now dead ;-)
> * Been playing around with alternate desktop showing.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150322/735e8b19/attachment-0001.html>