Review Request 123103: Use Animator for TabGroup transitions

David Edmundson david at davidedmundson.co.uk
Sun Mar 22 20:56:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123103/#review77928
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On March 22, 2015, 7:58 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123103/
> -----------------------------------------------------------
> 
> (Updated March 22, 2015, 7:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This reduces stuttering when switching between tabs of lazyloaded pages which happens, for instance, in Kickoff, especially with the faster animations we now have.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TabGroup.qml c01747e 
> 
> Diff: https://git.reviewboard.kde.org/r/123103/diff/
> 
> 
> Testing
> -------
> 
> Started plasmashell, switched between Kickoff tabs rapidly. Initial stutter is gone.
> 
> The enabled is needed to when Kickoff closes it returns to the favorites page immediately and you're not greeted with the animation from the previous state.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150322/4a607eb9/attachment.html>


More information about the Plasma-devel mailing list