Review Request 123104: Use PlasmaComponents.TextArea as a base in the notes applet

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123104/#review77927
-----------------------------------------------------------

Ship it!



applets/notes/package/contents/ui/main.qml (line 90)
<https://git.reviewboard.kde.org/r/123104/#comment53430>

    Colour is spelled different on this line and line 91. Even though I clearly wrote both at the same time.
    
    (not a review comment, I just found it interesting)


- David Edmundson


On March 22, 2015, 7:55 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123104/
> -----------------------------------------------------------
> 
> (Updated March 22, 2015, 7:55 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> This enables us to remove quite some hacks and poilerplate code, and also gives us the usual text interaction context menu for free
> 
> 
> Diffs
> -----
> 
>   applets/notes/package/contents/ui/main.qml d8ed784 
> 
> Diff: https://git.reviewboard.kde.org/r/123104/diff/
> 
> 
> Testing
> -------
> 
> Formatting options still work, the font size/rendering looks a bit different though, perhaps I do need to set all the font properties individually as before? :(
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150322/ff20d2af/attachment-0001.html>