Review Request 123040: Make selection in krunner wrapping

Pinak Ahuja pinak.ahuja at gmail.com
Fri Mar 20 16:14:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123040/#review77840
-----------------------------------------------------------


Git commit 05570618369027c8636db9abbe3726ece6fe8e72 by Pinak Ahuja.
Committed on 20/03/2015 at 15:55.
Pushed by pinakahuja into branch 'master'.

Make selection in ResultsView (and therefore Krunner) wrapping

Now pressing tab at end of the list in krunner makes the selection wrap to top, similarly for shift+tab when at start of list makes selection wrap to bottom.

M  +1    -1    lib/qml/ResultsView.qml

http://commits.kde.org/milou/05570618369027c8636db9abbe3726ece6fe8e72

- Pinak Ahuja


On March 20, 2015, 4:14 p.m., Pinak Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123040/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 4:14 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Bugs: 345301
>     http://bugs.kde.org/show_bug.cgi?id=345301
> 
> 
> Repository: milou
> 
> 
> Description
> -------
> 
> When selection is at end and tab is pressed it wraps around to top, also works when at top when shift+tab is pressed
> 
> 
> Diffs
> -----
> 
>   lib/qml/ResultsView.qml 0eac7b8 
> 
> Diff: https://git.reviewboard.kde.org/r/123040/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested on my pc, works as described.
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150320/41fe405f/attachment.html>


More information about the Plasma-devel mailing list