Review Request 123040: Make selection in krunner wrapping

Vishesh Handa me at vhanda.in
Fri Mar 20 13:09:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123040/#review77833
-----------------------------------------------------------

Ship it!


Go ahead then :)

- Vishesh Handa


On March 18, 2015, 7:06 p.m., Pinak Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123040/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 7:06 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Bugs: 345301
>     http://bugs.kde.org/show_bug.cgi?id=345301
> 
> 
> Repository: milou
> 
> 
> Description
> -------
> 
> When selection is at end and tab is pressed it wraps around to top, also works when at top when shift+tab is pressed
> 
> 
> Diffs
> -----
> 
>   lib/qml/ResultsView.qml 0eac7b8 
> 
> Diff: https://git.reviewboard.kde.org/r/123040/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested on my pc, works as described.
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150320/e14b2c46/attachment.html>


More information about the Plasma-devel mailing list