Review Request 123047: explicitly find and use kdbusaddons

Martin Klapetek martin.klapetek at gmail.com
Thu Mar 19 11:48:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123047/#review77733
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Klapetek


On March 19, 2015, 12:36 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123047/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 12:36 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> the kded module needs the KDEDModule header which is provided by
> kdbusaddons. previously this was implicitly pulled in by frameworks.
> frameworks recently got a public dependency cleanup so now it is not pulled
> in anymore; making the build fail.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f9028d3b387d462a584e299b871dd6cc2fdc9907 
>   daemon/CMakeLists.txt f1e6efbdf205282076251d7b975a6a448f818873 
> 
> Diff: https://git.reviewboard.kde.org/r/123047/diff/
> 
> 
> Testing
> -------
> 
> make && make install && make test
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150319/795e6574/attachment.html>


More information about the Plasma-devel mailing list