Review Request 123040: Make selection in krunner wrapping

[Vishesh Handa]

> On March 18, 2015, 10:36 p.m., Aleix Pol Gonzalez wrote:
> > But do we really want this?
> 
> Vishesh Handa wrote:
>     Doesn't seem like a bad idea. Specially since someone has asked for it. Any particular reason you're against this?
> 
> Pinak Ahuja wrote:
>     In my opinion it would be better than the current behavior in which the tab button becomes useless at then end of results.
> 
> Marco Martin wrote:
>     +1
>     Aleix: I think so, even if just for consistency with the rest of the world, try tab with any qwidget based dialog and this is the behavior of the tab button (I would consider it a bug where it doesn't do this).

I just checked, and KRunner 4 did not do this as well.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123040/#review77712
-----------------------------------------------------------


On March 18, 2015, 7:06 p.m., Pinak Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123040/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 7:06 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Bugs: 345301
>     http://bugs.kde.org/show_bug.cgi?id=345301
> 
> 
> Repository: milou
> 
> 
> Description
> -------
> 
> When selection is at end and tab is pressed it wraps around to top, also works when at top when shift+tab is pressed
> 
> 
> Diffs
> -----
> 
>   lib/qml/ResultsView.qml 0eac7b8 
> 
> Diff: https://git.reviewboard.kde.org/r/123040/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested on my pc, works as described.
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150319/25ece068/attachment.html>