Review Request 122948: Use fontSizeMode Text.Fit for NotificationIcon

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122948/#review77484
-----------------------------------------------------------

Ship it!


YES, PLEASE!!

Thank you.

- Martin Klapetek


On March 14, 2015, 4:13 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122948/
> -----------------------------------------------------------
> 
> (Updated March 14, 2015, 4:13 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> https://www.kde.org/announcements/plasma-5.2/full-screen.png
> There's nothing more to say. (Also use Connections rather than temp property)
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationIcon.qml 1449c19 
> 
> Diff: https://git.reviewboard.kde.org/r/122948/diff/
> 
> 
> Testing
> -------
> 
> Font now automatically scales with the icon. Alignment can still be a little bit off at times but properly centering text is a horrible task, also given the frame and everything else is themable. We lack the triangle indicators now, though.
> 
> 
> File Attachments
> ----------------
> 
> Before in tray
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/14/38fc6d1c-a1f7-4ace-8df3-5803516862f8__notificationiconbefore.png
> After in tray
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/14/4cf0dd62-7d14-4f9c-81aa-045d5f02b709__notificationiconafter.png
> On Desktop
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/14/b5111380-e5f2-4f45-93e5-fb84da26b711__notificationiconafter1.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150314/4cdefe46/attachment.html>