Review Request 122332: KQuickControls IconDialog

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
-----------------------------------------------------------

(Updated März 14, 2015, 9:41 vorm.)


Review request for Plasma and Daniel Vrátil.


Changes
-------

Fix window modality once and for all
- NonModal: Dialog appears but blocks neither plasma nor the config dialog
- WindowModal (default): Dialog appears and blocks the config dialog but rest of Plasma stays responsive
- ApplicationModal: Dialog blocks the entrie application

It seems setWindowModality(Qt::WindowModal) does not imply setModal(false)


Repository: kdeclarative


Description
-------

This patch adds KQuickControls wrapper around KIconDialog similar to how the ColorDialog and other QtQuick Dialogs work. This can be used, for instance, in Kickoff's config UI to provide a picker for a custom item.

It is an initial draft and lacks for example window modality as I couldn't figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic inside) and I'm also not sure about the lifecycle/ownership of the dialog, I've seen a lot of fixes for issues in that area on Review Board.


Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt d5713a0 
  src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp cee2360 

Diff: https://git.reviewboard.kde.org/r/122332/diff/


Testing
-------

For testing I added a button to Kickoff that allows to open the dialog and the button icon source is bound to the dialog's iconName property. Didn't test the icon source/user/custom path stuff.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150314/2eb5f7a7/attachment.html>