Review Request 122919: Remove unused dependencies.

Hrvoje Senjan hrvoje.senjan at gmail.com
Fri Mar 13 16:30:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122919/#review77431
-----------------------------------------------------------



src/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122919/#comment53170>

    grep -irn xfixes
    
    src/CMakeLists.txt:50:if (X11_Xfixes_FOUND)
    src/CMakeLists.txt:51:   target_link_libraries(kcm_sddm ${X11_Xfixes_LIB})
    src/CMakeLists.txt:52:endif (X11_Xfixes_FOUND)
    src/cursortheme/cursortheme.cpp:31:#ifdef HAVE_XFIXES
    src/cursortheme/cursortheme.cpp:33:#  include <X11/extensions/Xfixes.h>
    src/cursortheme/cursortheme.cpp:144:#ifdef HAVE_XFIXES
    src/cursortheme/cursortheme.cpp:146:    if (haveXfixes())
    src/cursortheme/cursortheme.cpp:148:        XFixesSetCursorName(QX11Info::display(), cursor,
    src/cursortheme/cursortheme.cpp:154:bool CursorTheme::haveXfixes()
    src/cursortheme/cursortheme.cpp:158:#ifdef HAVE_XFIXES
    src/cursortheme/cursortheme.cpp:163:    if (XFixesQueryExtension(QX11Info::display(), &event_base, &error_base))
    src/cursortheme/cursortheme.cpp:166:        XFixesQueryVersion(QX11Info::display(), &major, &minor);
    src/cursortheme/cursortheme.h:102:        static bool haveXfixes();
    src/cursortheme/cursortheme.h:119:        // Convenience function that uses Xfixes to tag a cursor with a name


- Hrvoje Senjan


On March 12, 2015, 4:30 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122919/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 4:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> -------
> 
> I can't find any reference to these dependencies, so remove them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 52e1ace5fb9cee4afa0711b4f6bc0b851500d427 
>   src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c 
> 
> Diff: https://git.reviewboard.kde.org/r/122919/diff/
> 
> 
> Testing
> -------
> 
> Inspected source. Builds. No library links to the affected dependencies before and after the change.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150313/b5310fbd/attachment-0001.html>


More information about the Plasma-devel mailing list