Change in plasma-framework[master]: Disconnect connections to d->mainItem when it has changed

[David Edmundson (Code Review)]

David Edmundson has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/418

Change subject: Disconnect connections to d->mainItem when it has changed
......................................................................

Disconnect connections to d->mainItem when it has changed

This is needed as otherwise we can have a situation where d->mainItem is
null, yet we still have connections to an object that exists causing a
crash if the old mainItem resizes.

BUG: 343963
Change-Id: Ie398a591915fa02d4d97ce7ad5289e3b24038087
---
M src/plasmaquick/dialog.cpp
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/18/418/1

diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp
index 0d820a6..097cc31 100644
--- a/src/plasmaquick/dialog.cpp
+++ b/src/plasmaquick/dialog.cpp
@@ -693,6 +693,9 @@
 void Dialog::setMainItem(QQuickItem *mainItem)
 {
     if (d->mainItem != mainItem) {
+        disconnect(d->mainItem, 0, this, 0);
+        disconnect(d->mainItemLayout, 0, this, 0);
+
         d->hintsCommitTimer.stop();
         if (d->mainItem) {
             d->mainItem->setVisible(false);

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/418
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie398a591915fa02d4d97ce7ad5289e3b24038087
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: David Edmundson <david at davidedmundson.co.uk>