Review Request 122916: Fix displaying label1 in job notifications

David Rosca nowrep at gmail.com
Thu Mar 12 20:40:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122916/
-----------------------------------------------------------

(Updated March 12, 2015, 8:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 6b462e70ec6072b9861b57e720407ada9a78ac80 by David Rosca to branch Plasma/5.2.


Repository: plasma-workspace


Description
-------

Repeater in JobDetailsItem.qml is iterating over jobItem (JobDelegate.qml) properties, but it only contains label0.
This patch moves the label1 + labelName1 properties from JobDetailsItem.qml to JobDelegate.qml


Diffs
-----

  applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab 
  applets/notifications/package/contents/ui/JobDetailsItem.qml 2f557ee 

Diff: https://git.reviewboard.kde.org/r/122916/diff/


Testing
-------

Notifications now correctly shows both labels (in my case From and To labels in receive files notification)


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/0732646d/attachment-0001.html>


More information about the Plasma-devel mailing list