Review Request 122887: Load and wrap the QML-only version of kcms if possible

Marco Martin notmart at gmail.com
Thu Mar 12 14:58:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122887/
-----------------------------------------------------------

(Updated March 12, 2015, 2:58 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kcmutils


Description
-------

This makes KCMLoader try to load the qobject-only, qml based kcms as well, if it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it as loaded module (the class itself is not exported, so no new symbols).
This makes systemsettings, kcmshell and any config dialog that loads kcms transparently load those config modules not based upon KCModule


Diffs (updated)
-----

  CMakeLists.txt cb4ae5d 
  src/CMakeLists.txt f7b869f 
  src/kcmoduleloader.cpp 5ccf236 
  src/kcmoduleqml.cpp PRE-CREATION 
  src/kcmoduleqml_p.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122887/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/49d44f53/attachment.html>


More information about the Plasma-devel mailing list