Review Request 122915: check we are started from the correct thread before starting timer

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122915/#review77371
-----------------------------------------------------------

Ship it!


My apologies, please leave it in AutoConnection. Other than that it should go in.

I'm still unsure if there's nothing else that will fail on the multithreaded case but this is a step forward nevertheless.

- Aleix Pol Gonzalez


On March 12, 2015, 2:38 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122915/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 2:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible)
> there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case 
> 
> during normal svg resizes, all goes as before
> 
> 
> Diffs
> -----
> 
>   src/plasma/theme.cpp 18d4ed6 
> 
> Diff: https://git.reviewboard.kde.org/r/122915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/594fd1fe/attachment.html>