Review Request 122915: check we are started from the correct thread before starting timer

[Aleix Pol Gonzalez]

> On March 12, 2015, 2:28 p.m., Aleix Pol Gonzalez wrote:
> > src/plasma/theme.cpp, line 421
> > <https://git.reviewboard.kde.org/r/122915/diff/2/?file=354540#file354540line421>
> >
> >     You'll need to pass the ConnectionType if you want this to fix the issue. Qt::BlockingQueuedConnection would be the drop replacement, but Qt::QueuedConnection is faster and enough in this case.
> 
> David Edmundson wrote:
>     it defaults to Auto which is Queued if it needs to be.

True, I should have read the documentation. >.<

(Default) If the receiver lives in the thread that emits the signal, Qt::DirectConnection is used. Otherwise, Qt::QueuedConnection is used. The connection type is determined when the signal is emitted.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122915/#review77365
-----------------------------------------------------------


On March 12, 2015, 2:38 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122915/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 2:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible)
> there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case 
> 
> during normal svg resizes, all goes as before
> 
> 
> Diffs
> -----
> 
>   src/plasma/theme.cpp 18d4ed6 
> 
> Diff: https://git.reviewboard.kde.org/r/122915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/1e9b4525/attachment.html>