Review Request 122915: check we are started from the correct thread before starting timer

[Aleix Pol Gonzalez]

> On March 12, 2015, 2:12 p.m., Aleix Pol Gonzalez wrote:
> > src/plasma/theme.cpp, line 421
> > <https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line421>
> >
> >     If that's the case, then we will need locking, no?
> >     
> >     We don't want 2 different threads modifying the class members at the same time...
> 
> Marco Martin wrote:
>     seems things gets called from a different thread once right after being created..
>     that would make it the case for every single class created from QML i guess?
>     needs more investigation, but this can potentially unveil a deeper problem in QML?

Can you maybe provide a backtrace of the Q_UNLIKELY path? It can be interesting to understand what's going on.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122915/#review77360
-----------------------------------------------------------


On March 12, 2015, 2:25 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122915/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 2:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible)
> there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case 
> 
> during normal svg resizes, all goes as before
> 
> 
> Diffs
> -----
> 
>   src/plasma/theme.cpp 18d4ed6 
> 
> Diff: https://git.reviewboard.kde.org/r/122915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/be4816b9/attachment.html>