Review Request 122915: check we are started from the correct thread before starting timer
David Edmundson
david at davidedmundson.co.uk
Thu Mar 12 12:50:39 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122915/#review77358
-----------------------------------------------------------
Good catch?
src/plasma/theme.cpp
<https://git.reviewboard.kde.org/r/122915/#comment53120>
Would it work to:
QMetaObject::invoke(d->rectSaveTimer, SLOT("start()"));
that will mean we always use the timer?
- David Edmundson
On March 12, 2015, 10:34 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122915/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 10:34 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible)
> there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case
>
> during normal svg resizes, all goes as before
>
>
> Diffs
> -----
>
> src/plasma/theme.cpp 18d4ed6
>
> Diff: https://git.reviewboard.kde.org/r/122915/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/4877131c/attachment.html>
More information about the Plasma-devel
mailing list