Review Request 122914: Take Shown and Hidden status in account when showing sidebar

Marco Martin notmart at gmail.com
Thu Mar 12 12:05:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122914/#review77351
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On March 12, 2015, 4:24 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122914/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 4:24 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 344795
>     https://bugs.kde.org/show_bug.cgi?id=344795
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> - if clicked on arrow show sidebar
> - if clicked on always hidden applet show sidebar
> - if clicked on always shown applet hide sidebar
> - in case of passive applet show sidebar
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 0b9f96f 
> 
> Diff: https://git.reviewboard.kde.org/r/122914/diff/
> 
> 
> Testing
> -------
> 
> Checked all cases
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/4ffdab0a/attachment.html>


More information about the Plasma-devel mailing list