Review Request 122842: Allow selecting notifications position on screen

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/
-----------------------------------------------------------

(Updated March 11, 2015, 7:09 p.m.)


Review request for Plasma.


Changes
-------

Forgot to stage the new file ;)


Bugs: 344841
    https://bugs.kde.org/show_bug.cgi?id=344841


Repository: plasma-workspace


Description
-------

Allows to select each corner and top or bottom edges of the screen.

The radio selection thing is currently a bit ugly and I'd like to ask for suggestions on it (I originally wanted to add VDG here but there's no vdg group (?) so I'll post in the forums).


Diffs (updated)
-----

  applets/notifications/package/contents/config/main.xml 6e55fe8 
  applets/notifications/package/contents/ui/Notifications.qml 4312774 
  applets/notifications/package/contents/ui/ScreenPositionSelector.qml PRE-CREATION 
  applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 
  applets/notifications/plugin/notificationshelper.h ca0b63b 
  applets/notifications/plugin/notificationshelper.cpp e7c4e29 

Diff: https://git.reviewboard.kde.org/r/122842/diff/


Testing
-------

All positions work


File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png
New Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150311/42b0eafe/attachment.html>