Review Request 122886: QML-only KCM base

[David Edmundson]

> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.cpp, line 102
> > <https://git.reviewboard.kde.org/r/122886/diff/1/?file=354025#file354025line102>
> >
> >     when combined with your other KCModule patch you have a crash.
> >     
> >     From KCModule docs:
> >     This sets the KAboutData returned by aboutData() The about data is now owned by KCModule.
> >     
> >     So this will result in a double delete.
> >     Same for the delete in setAboutData.
> 
> Marco Martin wrote:
>     hmm, would work actually creating a copy of this about data in the wrapper class?
> 
> David Edmundson wrote:
>     Yeah, I think that would work.
> 
> Marco Martin wrote:
>     thinking about it i'm not sure about the double delete (i don't get a crash after all) since KCModuleQml never gets an aboutdata by its own but just returns this class instance in the reimplementation of virtual aboutData() (so the KCModule instance never gets a valid d->_aboutData), opposed to do a setAboutData(d->configModule->aboutData()) in which would definitely crash

oh, you're right. I got confused as we were signally and proxying everything else.
You can close this.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
-----------------------------------------------------------


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or as the "KCM" attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -----
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150311/b86f1acb/attachment.html>