Review Request 122899: Set directory mimetype for smb protocol
Lukáš Tinkl
lukas at kde.org
Wed Mar 11 02:23:02 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122899/#review77284
-----------------------------------------------------------
Ship it!
smb/kio_smb_browse.cpp
<https://git.reviewboard.kde.org/r/122899/#comment53075>
Correct indentation?
- Lukáš Tinkl
On Bře. 10, 2015, 11:18 odp., Rajeesh K Nambiar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122899/
> -----------------------------------------------------------
>
> (Updated Bře. 10, 2015, 11:18 odp.)
>
>
> Review request for Plasma.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> Browsing samba shares using Dolphin doesn't show directory icons properly. This is due to missing mimetype in UDSEntry. Set the mimetype "inode/directory" for directories.
>
>
> Diffs
> -----
>
> smb/kio_smb_browse.cpp 67e2fa0
>
> Diff: https://git.reviewboard.kde.org/r/122899/diff/
>
>
> Testing
> -------
>
> Tested with kio-extras 5.2.1. See attached before and after screenshots of Dolphin.
>
>
> File Attachments
> ----------------
>
> samba folder before
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png
> samba folder after
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png
>
>
> Thanks,
>
> Rajeesh K Nambiar
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150311/0ca29d7f/attachment.html>
More information about the Plasma-devel
mailing list