Review Request 122332: KQuickControls IconDialog
Martin Klapetek
martin.klapetek at gmail.com
Tue Mar 10 23:30:51 UTC 2015
> On March 10, 2015, 9:36 p.m., Kai Uwe Broulik wrote:
> > I tried using setTransientParent but the windowHandle is null before I show the dialog but changing it afterwards doesn't work.
You can call m_dialog->winId() before, that will ensure that windowHandle is created without needing to show the dialog first
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review77270
-----------------------------------------------------------
On March 10, 2015, 9:03 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122332/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 9:03 p.m.)
>
>
> Review request for Plasma and Daniel Vrátil.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> This patch adds KQuickControls wrapper around KIconDialog similar to how the ColorDialog and other QtQuick Dialogs work. This can be used, for instance, in Kickoff's config UI to provide a picker for a custom item.
>
> It is an initial draft and lacks for example window modality as I couldn't figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic inside) and I'm also not sure about the lifecycle/ownership of the dialog, I've seen a lot of fixes for issues in that area on Review Board.
>
>
> Diffs
> -----
>
> src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt d5713a0
> src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION
> src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION
> src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp cee2360
>
> Diff: https://git.reviewboard.kde.org/r/122332/diff/
>
>
> Testing
> -------
>
> For testing I added a button to Kickoff that allows to open the dialog and the button icon source is bound to the dialog's iconName property. Didn't test the icon source/user/custom path stuff.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150310/167a3c9c/attachment-0001.html>
More information about the Plasma-devel
mailing list