Review Request 122332: KQuickControls IconDialog

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
-----------------------------------------------------------

(Updated März 10, 2015, 8:03 nachm.)


Review request for Plasma and Daniel Vrátil.


Changes
-------

Rebased.

Close dialog on destruction just to be sure. It requires Review 122893 because both openDialog and showDialog mess with the dialog's modality (either ApplicationModal or NonModal).

The Dialog is WindowModal. I added it to Kickoff and for some reason both the applet config dialog as well as all panels and the desktop get dimmed, whereas widget explorer is not. Using WindowModal causes all of plasma to be non-interactive while the dialog is there. I looked at QtQuick Dialogs because these seem to support proper modality but I ended up in some QPA madness and gave up. I didn't find a way to tell it which is the parent window, setParent(window()) didn't work because QDialog wants a QWidget parent.


Repository: kdeclarative


Description
-------

This patch adds KQuickControls wrapper around KIconDialog similar to how the ColorDialog and other QtQuick Dialogs work. This can be used, for instance, in Kickoff's config UI to provide a picker for a custom item.

It is an initial draft and lacks for example window modality as I couldn't figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic inside) and I'm also not sure about the lifecycle/ownership of the dialog, I've seen a lot of fixes for issues in that area on Review Board.


Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt d5713a0 
  src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp cee2360 

Diff: https://git.reviewboard.kde.org/r/122332/diff/


Testing
-------

For testing I added a button to Kickoff that allows to open the dialog and the button icon source is bound to the dialog's iconName property. Didn't test the icon source/user/custom path stuff.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150310/3a90b12e/attachment.html>