Review Request 122717: Improve tooltip layouting

[David Edmundson]

> On Feb. 26, 2015, 10:10 p.m., Kai Uwe Broulik wrote:
> > I'm now getting most of my headlines elided or wrapped:
> > "K-\n Menü"
> > "99%. Wird\n geladen" (battery)
> > "Aktualisierung..." (updater)
> > "KM..." (rather than KMail)
> > "Volume at\n 45%" (kmix)
> > "Donnerst..." (rather than Donnerstag, digitalclock)
> 
> Lukáš Tinkl wrote:
>     Yup, seeing the same here: http://developer.kde.org/~lukas/screenshots/tooltip.png
> 
> Sebastian Kügler wrote:
>     Thanks for the feedback! This patch indeed shortens the max width a bit, so it's likely the culprit. 
>     
>     Could you guys try changing 
>     
>     property int preferredTextWidth: units.gridUnit * 20
>     
>     to 25 or 30 and see if that fixes the problems? I'd like to not make it too wide, so we'll need some testing here, I think.
> 
> Martin Klapetek wrote:
>     25 nor 30 does any difference here, in fact, not even 40 makes any difference at all
> 
> Sebastian Kügler wrote:
>     Thanks for the testing.
>     
>     I've investigated a bit further, though without any conclusive solution. Let's take a step back.
>     
>     The implicitWidth of the text item (which is the width the text would be rendered at in one single line without linebreaks) set min and max width of the surrounding layout, which is propagated into the root item's Layout.min and Layout.max widths. On my system (Intel, dunno if it makes a difference), this works correctly, the dialog's size correctly makes the tooltip window resize and fit.
>     
>     The bug we're seeing looks like the dialog size is not correctly scaled up, so the text in the heading either breaks, or elides. What should happen here is that the mainitems Layout sizing takes preference, and the tooltip window is scaled to the content, not the other way around.
>     
>     I'm puzzled for now.

Martin/ Lukas can you reproduce on the test case in plasma-frameworkst/tests/tooltip.qml adding any new entries if needed

Can you set a rightAnchor on the topmost RowLayout and see if that fixes it?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122717/#review76692
-----------------------------------------------------------


On Feb. 26, 2015, 3:46 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122717/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 3:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Improve tooltip layouting
> 
> This patch ports the default tooltip away from custom spacing,
> positioning and Row/Column to QtQuick.Layouts. It makes the sizing more
> predictable, and the code more modern and readable. Tooltips feel to
> behave a bit smoother with this patch.
> 
> In the process, this...
> - fixes spacing when no icon or image is set
> - limits the maximum height of the subtext to 8 lines (this prevents the
>   klipper tooltip for example from growing super-high)
> - Makes the icon on the LHS proportional to the text
> - Limits the width a bit more to prevent super-wide tooltips
> - makes it use units.gridUnit throughout
> 
> Changelog: Improve tooltip layout
> 
> This is the more radical approach to https://git.reviewboard.kde.org/r/122715/
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/private/DefaultToolTip.qml d1be6ae 
> 
> Diff: https://git.reviewboard.kde.org/r/122717/diff/
> 
> 
> Testing
> -------
> 
> Tested all applets' tooltips in the default panel
> 
> 
> File Attachments
> ----------------
> 
> launcher (old)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/a6c636ce-3aef-4d5a-82f0-d78f9dab19a1__old-kickoff.png
> pager (old)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fae793bb-2965-4a81-be27-08efce5b3838__old-pager.png
> kdeconnect (old)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fc079c52-be17-47cf-bd11-976aed566155__old-kdeconnect.png
> clock (old)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/8214146b-cdd4-41d7-b406-f6fc404585cc__old-clock.png
> new-kickoff.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/9a96304f-1deb-4f57-9417-121a95b7ed03__new-kickoff.png
> new-pager.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/e2c5738f-e701-4a5e-a179-cedc6bb55181__new-pager.png
> new-kdeconnect.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/0c73a854-de8a-4dc2-bd57-c22e0700dbb5__new-kdeconnect.png
> new-clock.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/7311d304-cdf3-4bf2-8fdc-519d1a4c020d__new-clock.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150305/b24e656c/attachment-0001.html>