Review Request 122823: Avoid KDE4 lingo in colors kcm
Jeremy Whiting
jpwhiting at kde.org
Thu Mar 5 02:37:59 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122823/#review77038
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On March 4, 2015, 6:49 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122823/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 6:49 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Avoid KDE4 lingo in colors kcm
>
> "non-Qt" applications is technically more correct since we're using the frameworksintegration Qt platform plugin. This also avoids the "KDE4" lingo in the ui.
>
>
> Diffs
> -----
>
> kcms/colors/colorsettings.ui 705d9b8cf6ca4f07975bff924813ff25957a9bd5
> kcms/colors/colorscm.cpp 463e90ba427c8e6fe9c9f2530291b2613455c0a7
>
> Diff: https://git.reviewboard.kde.org/r/122823/diff/
>
>
> Testing
> -------
>
> Checked if the checkbox's label is updated in the KCM.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150305/601b58ef/attachment.html>
More information about the Plasma-devel
mailing list