Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO
Marco Martin
notmart at gmail.com
Wed Mar 4 14:31:58 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122673/
-----------------------------------------------------------
(Updated March 4, 2015, 2:31 p.m.)
Review request for Plasma.
Repository: plasma-framework
Description
-------
(still in progress but here for feedback)
when QT_DEVICE_PIXELRATIO is something different from 1, the pixmaps generated by Svg will be scaled up to give a proper texture.
This is complementary but not replacing our current approach:
the pixelratio that can be accessed by units is now in relation to the qt pixel ratio, spacings are also adjusted accordingly (therefore, spaces and sizes won't need an integer value like pixelratio)
svg introduces also a scaleFactor property (that is pretty much like its old pixelRatio)
basically, scalefactor, will scale both the textures *and* all the reported sizes, (old method) pixelratio just scales textures without altering measures (like qt pixelratio likes)
they are now both used and combined, so a) we can have this working before supporting officially qt pixelratio when will be good enough but b) keeping the old mwthod working for the time being c) by using both at the sae time we can at least scale sizes of values != from integers, for screens that are too dense for 1 and not enough for 2
Diffs (updated)
-----
src/declarativeimports/core/framesvgitem.cpp dae8a4f
src/declarativeimports/core/iconitem.cpp 03f40c4
src/declarativeimports/core/svgitem.cpp 570c1c3
src/declarativeimports/core/units.h 6c038ba
src/declarativeimports/core/units.cpp a740145
src/plasma/framesvg.cpp 1bb3510
src/plasma/private/svg_p.h a31d0ac
src/plasma/svg.h 0bcbd7a
src/plasma/svg.cpp 0a0db5e
Diff: https://git.reviewboard.kde.org/r/122673/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150304/4707e9e5/attachment.html>
More information about the Plasma-devel
mailing list