Review Request 122736: [dataengines/geolocation] Use wifi data if available

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122736/
-----------------------------------------------------------

(Updated March 4, 2015, 2 p.m.)


Review request for Plasma, Jan Grulich and Lukáš Tinkl.


Changes
-------

* implemented Kai's suggestions
* added a (hidden) config key which defaults off


Repository: plasma-workspace


Description
-------

Adds a dependency to NetworkManager and queries the available wifi
access points to include in the request to the location service.


Diffs (updated)
-----

  CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489 
  dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5 
  dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e 
  dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e 
  dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc 

Diff: https://git.reviewboard.kde.org/r/122736/diff/


Testing
-------

Tested with my available networks and checked position on openstreetmaps. Basically it even put me in the right room of the building I'm in.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150304/a5451aa6/attachment.html>