Review Request 122800: Add a Wayland implementation for KWindowSystemPrivate

Martin Gräßlin mgraesslin at kde.org
Wed Mar 4 09:18:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122800/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: kwindowsystem


Description
-------

This is the same with KWindowSystemPrivateDummy, just that
::compositingActive returns true instead of false as the dummy
implementation does.

This ensures that usages depending on compositing state work
correctly. E.g. Plasma picks the right SVGs.

CHANGELOG: Add a dummy Wayland implementation for KWindowSystemPrivate


Diffs
-----

  src/kwindowsystem_p_wayland.h PRE-CREATION 
  src/kwindowsystem_wayland.cpp PRE-CREATION 
  src/CMakeLists.txt ef792e7c78b79a12870c875682c5ceb668ad5550 
  src/kwindowsystem.cpp 97dd6072a77f864b1e08287e8546cc29c24474c6 
  src/kwindowsystem_p.h fb7d90c6a0e650d2a90589b1a9687d1ffd6f43e3 

Diff: https://git.reviewboard.kde.org/r/122800/diff/


Testing
-------


File Attachments
----------------

Without: Plasma uses wrong SVG
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/04/1584791d-47fa-49b5-b766-0fc81728ad68__wayland-plasma-no-compositing.png
With: Plasma uses right SVG (black corners might be a KWin bug)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/04/b5bf7fcf-6913-43af-8bcf-e0bc30766783__wayland-plasma-compositing.png


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150304/c33c4dee/attachment.html>


More information about the Plasma-devel mailing list