Review Request 122766: Don't use a possibly non-existent property "animationsEnabled".
Elias Probst
mail at eliasprobst.eu
Wed Mar 4 07:23:15 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122766/
-----------------------------------------------------------
(Updated March 4, 2015, 7:23 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-desktop
Description
-------
**Commit MSG:**
```
This prevents the following error message on plasmashell startup:
default unknown:
file:///usr/share/plasma/plasmoids/org.kde.panel/contents/ui/main.qml:448:
Error: Cannot assign to non-existent property "animationsEnabled"
```
As I'm not sure what the hackery in the Timer element actually does, somebody needs to review this before I go and commit it.
Diffs
-----
containments/panel/contents/ui/main.qml 2772bfe934ca7a80e58953c15ed76d99c358bbbb
Diff: https://git.reviewboard.kde.org/r/122766/diff/
Testing
-------
- error message on plasmashell startup is gone
- animations in panel still work
Thanks,
Elias Probst
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150304/125e9ded/attachment.html>
More information about the Plasma-devel
mailing list