Review Request 122795: Fix crashes when attempting to load invalid package

[Alex Richardson]

> On March 3, 2015, 11:39 p.m., Aleix Pol Gonzalez wrote:
> > Would it maybe be possible to get a unit test for the applet loading?

I think all the crashes I got were due to https://git.reviewboard.kde.org/r/122733/. Now that that is fixed, the mainscript is always found. I'll try and create a unit test simulating that case.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122795/#review76973
-----------------------------------------------------------


On March 3, 2015, 7:32 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122795/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 7:32 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> AppletQuickItem: don't crash if d->qmlObject->mainComponent() is null
> 
> The if branch is entered if d->qmlObject->mainComponent() is null, but then
> it is unconditionally dereferenced causing a potential crash
> 
> 
> ----
> 
> Don't crash if mainscript is missing
> 
> ----
> Better error message if applet could not be loaded
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/appletquickitem.cpp 1abedf0d9089c69d12b981d4597363cb1c6fc443 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d452cadbe6afa6a51a127b6bc98ce137ddae 
> 
> Diff: https://git.reviewboard.kde.org/r/122795/diff/
> 
> 
> Testing
> -------
> 
> no longer crashes, prints an error message instead
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150304/41c4501b/attachment.html>