Review Request 122667: Some tools for easily do qml based apps using KPackage

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122667/#review76958
-----------------------------------------------------------



src/kdeclarative/qmlobject.h
<https://git.reviewboard.kde.org/r/122667/#comment52937>

    typo



src/kdeclarative/qmlobject.cpp
<https://git.reviewboard.kde.org/r/122667/#comment52938>

    question, where does 
    
    KPackage/GenericQML come from?



src/kpackagelauncherqml/main.cpp
<https://git.reviewboard.kde.org/r/122667/#comment52939>

    leaks.
    
    not that important as we want it to have the lifespan of the program, but it'll show up in valgrind logs.



src/kpackagelauncherqml/main.cpp
<https://git.reviewboard.kde.org/r/122667/#comment52940>

    we load this, we set the authors then don't do anything with it?
    
    Is it used implicitly?



src/kpackagelauncherqml/main.cpp
<https://git.reviewboard.kde.org/r/122667/#comment52944>

    I think one should go with implicit size if valid first?



src/kpackagelauncherqml/main.cpp
<https://git.reviewboard.kde.org/r/122667/#comment52941>

    returning here is weird.



src/kpackagelauncherqml/main.cpp
<https://git.reviewboard.kde.org/r/122667/#comment52943>

    if the root item is a QObject (which is valid, ableit odd) we just pause doing nothing with no feedback.



tests/helloworld/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/122667/#comment52942>

    A test where the main item isn't a window might be good.


- David Edmundson


On March 3, 2015, 10:14 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122667/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 10:14 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps
> 
> It adds 3 things:
> * KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense
> * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed)
> * KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 52a698a 
>   src/CMakeLists.txt 32da8a5 
>   src/kdeclarative/CMakeLists.txt 052b9e2 
>   src/kdeclarative/qmlobject.h a0a74d3 
>   src/kdeclarative/qmlobject.cpp 00478b4 
>   src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION 
>   src/kpackagelauncherqml/main.cpp PRE-CREATION 
>   src/quickaddons/CMakeLists.txt 8272f1f 
>   tests/CMakeLists.txt a8abfaf 
>   tests/helloworld/contents/ui/main.qml PRE-CREATION 
>   tests/helloworld/metadata.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122667/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150303/cd1b16a3/attachment-0001.html>