Review Request 122781: Enable high DPI pixmaps in systemsettings

Ben Cooksley bcooksley at kde.org
Tue Mar 3 07:26:37 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122781/#review76938
-----------------------------------------------------------


Coding all looks fine from my perspective.
I don't have a Plasma 5 environment though - so can't comment on how well this works.

- Ben Cooksley


On March 2, 2015, 6:51 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122781/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 6:51 p.m.)
> 
> 
> Review request for Plasma and Ben Cooksley.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> Enable high DPI pixmaps in systemsettings
> 
> 
> Diffs
> -----
> 
>   app/main.cpp 150ca90 
> 
> Diff: https://git.reviewboard.kde.org/r/122781/diff/
> 
> 
> Testing
> -------
> 
> Went through every KCM in systemsettings with QT_DEVICE_PIXEL_RATIO=2,including tree view and checked that nothing was broken.
> 
> 
> A few things are still low res pixmaps scaled up, but without this everything is low res pixmaps scaled up, so it's no worse.
> Full list of TODO tasks at https://todo.kde.org/?controller=task&action=show&task_id=981.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150303/ef557dbc/attachment.html>


More information about the Plasma-devel mailing list