Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons
Sebastian Kügler
sebas at kde.org
Tue Mar 3 02:43:20 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122239/#review76937
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Kügler
On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122239/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 11:54 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> Since there are already like 10 copies of the ProcessRunner for all kinds of plasmoids wanting to open a KCM, this adds a KCMShell.open("foo") and KCMShell.open(["foo", "bar", "baz"]) singleton.
>
>
> Diffs
> -----
>
> src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION
> src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed
>
> Diff: https://git.reviewboard.kde.org/r/122239/diff/
>
>
> Testing
> -------
>
> Works. Dunno if the name causes clashes or this is the right place to put it.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150303/86d6b3af/attachment.html>
More information about the Plasma-devel
mailing list