Review Request 122598: Add separate checkbox for automatically lock screen

Sebastian Kügler sebas at kde.org
Tue Mar 3 02:42:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122598/#review76936
-----------------------------------------------------------

Ship it!


Looking good as far as I can see.

- Sebastian Kügler


On Feb. 26, 2015, 12:06 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122598/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This improves usability over setting the timeout to 0.
> Defaults behaviour is unchanged
> 
> BUG: 342596
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/kcm/kcm.ui fe32cf3 
>   ksmserver/screenlocker/ksldapp.cpp 6c41f4e 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 
> 
> Diff: https://git.reviewboard.kde.org/r/122598/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> a.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png
> aleix suggests doing this...thoughts?
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/4d9fbaed-dca8-4000-913e-c352696a975f__a1.png
> this?
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/e4196951-0578-4149-914f-d310efe70ce2__this.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150303/5c741f68/attachment.html>


More information about the Plasma-devel mailing list