Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO

[Sebastian Kügler]

> On March 2, 2015, 6:26 p.m., Martin Klapetek wrote:
> > File Attachment: screenshot.png - screenshot.png
> > <https://git.reviewboard.kde.org/r/122742/#fcomment368>
> >
> >     I'd suggest FormLayout/GridLayout so these are aligned

I'd suggest the same. Perhaps we can even move the message about the setting taking effect next to the combo?


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122742/#review76917
-----------------------------------------------------------


On March 2, 2015, 6:16 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122742/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 6:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kscreen
> 
> 
> Description
> -------
> 
> Add a combo box to select QT_DEVICE_PIXEL_RATIO
> 
> Probably not worth merging just yet, given some other parts are broken...but it's a step forwards.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6f1769a 
>   kcm/src/CMakeLists.txt 8c693b5 
>   kcm/src/kcm_kscreen.cpp b9f3596 
>   kcm/src/widget.h 88d6407 
>   kcm/src/widget.cpp 9ff8af6 
> 
> Diff: https://git.reviewboard.kde.org/r/122742/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> screenshot.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150303/596408de/attachment.html>