Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO

David Edmundson david at davidedmundson.co.uk
Mon Mar 2 18:16:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122742/
-----------------------------------------------------------

(Updated March 2, 2015, 6:16 p.m.)


Review request for Plasma.


Changes
-------

add screenie.

I'm not entirely happy with it, so suggestions welcome.


Repository: kscreen


Description
-------

Add a combo box to select QT_DEVICE_PIXEL_RATIO

Probably not worth merging just yet, given some other parts are broken...but it's a step forwards.


Diffs
-----

  CMakeLists.txt 6f1769a 
  kcm/src/CMakeLists.txt 8c693b5 
  kcm/src/kcm_kscreen.cpp b9f3596 
  kcm/src/widget.h 88d6407 
  kcm/src/widget.cpp 9ff8af6 

Diff: https://git.reviewboard.kde.org/r/122742/diff/


Testing
-------


File Attachments (updated)
----------------

screenshot.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150302/3f46bb5c/attachment.html>


More information about the Plasma-devel mailing list