Review Request 122766: Don't use a possibly non-existent property "animationsEnabled".
Marco Martin
notmart at gmail.com
Mon Mar 2 09:31:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122766/#review76872
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On Feb. 28, 2015, 10:47 p.m., Elias Probst wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122766/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 10:47 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> **Commit MSG:**
> ```
> This prevents the following error message on plasmashell startup:
>
> default unknown:
> file:///usr/share/plasma/plasmoids/org.kde.panel/contents/ui/main.qml:448:
> Error: Cannot assign to non-existent property "animationsEnabled"
> ```
>
>
> As I'm not sure what the hackery in the Timer element actually does, somebody needs to review this before I go and commit it.
>
>
> Diffs
> -----
>
> containments/panel/contents/ui/main.qml 2772bfe934ca7a80e58953c15ed76d99c358bbbb
>
> Diff: https://git.reviewboard.kde.org/r/122766/diff/
>
>
> Testing
> -------
>
> - error message on plasmashell startup is gone
> - animations in panel still work
>
>
> Thanks,
>
> Elias Probst
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150302/5ee25108/attachment.html>
More information about the Plasma-devel
mailing list