Review Request 124191: Ensure configure-time X11 path lookup is found

David Edmundson david at davidedmundson.co.uk
Sat Jun 27 01:51:52 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124191/#review81794
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On June 26, 2015, 11:24 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124191/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 11:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I just rebooted and my keyboard wasn't working. After investigating a bit, I realized it was because Rules::readRules was unable to find evdev.xml. The lookup is done at configure-time and I think it's better to fail it works than to eventually realize it can't work.
> 
> 
> Diffs
> -----
> 
>   ConfigureChecks.cmake 34390d1 
> 
> Diff: https://git.reviewboard.kde.org/r/124191/diff/
> 
> 
> Testing
> -------
> 
> I changed the path locally and fixed the issue.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150627/91f5a888/attachment.html>


More information about the Plasma-devel mailing list