Review Request 124172: Fix touchpad backend initialization

Martin Gräßlin mgraesslin at kde.org
Fri Jun 26 05:45:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124172/#review81767
-----------------------------------------------------------


logic seems ok to me, I haven't tested of course.

And don't worry about having missed the 5.3.2 release - it's introducing new translations, so it was a no-go for the branch anyway.


kcms/touchpad/src/backends/x11/xlibbackend.cpp (line 281)
<https://git.reviewboard.kde.org/r/124172/#comment56085>

    please use i18nc - I think translators have a hard problem understanding how they need to translate "Libinput" and "Synaptics" otherwise.


- Martin Gräßlin


On June 25, 2015, 10:50 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124172/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 10:50 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 344958
>     https://bugs.kde.org/show_bug.cgi?id=344958
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> kcm_touchpad supports both libinput and synaptics backends, but with libinput driver is uninstalled and synaptics driver installed, users get error 'No touchpad found'.
> Also see Fedora bug https://bugzilla.redhat.com/show_bug.cgi?id=1199825
> 
> This missed 5.3.2 by a whisker :-(
> 
> 
> Diffs
> -----
> 
>   kcms/touchpad/src/backends/x11/xlibbackend.cpp 2acb162 
> 
> Diff: https://git.reviewboard.kde.org/r/124172/diff/
> 
> 
> Testing
> -------
> 
> Built Fedora 22 RPMS, locally tested.
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150626/9ad89bca/attachment-0001.html>


More information about the Plasma-devel mailing list