Review Request 124151: Add a default icon to notifications popup

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124151/
-----------------------------------------------------------

(Updated June 25, 2015, 9:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit eb5693810e6d0e907071e15dc1acf8b32dac534a by Martin Klapetek to branch Plasma/5.3.


Repository: plasma-workspace


Description
-------

Currently there's none and if there's just a summary text ($ notify-send text), the notification popup looks strange. Adding the default icon makes it look more consistent and not totally-out-of-place-command-line-notification.


Diffs
-----

  applets/notifications/package/contents/ui/NotificationItem.qml 9e413f9 

Diff: https://git.reviewboard.kde.org/r/124151/diff/


Testing
-------

See screenshot


File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/0d8a0ee1-af00-410c-80f1-79190f51daf5__notification-default-icon.png
No icon notification
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/23/06c769be-b5fc-4360-9aac-6f3179601d92__notifications-layout1.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150625/ee2b865e/attachment.html>