Review Request 124151: Add a default icon to notifications popup

[Philipp A.]

> On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote:
> > I actually really like it, perhaps we should make KDialog passive popup not set an icon by default now

i also like the no-icon no-space version. why add something that just takes up unnecessary space and has no informational value?


- Philipp


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124151/#review81698
-----------------------------------------------------------


On June 23, 2015, 9:42 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124151/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 9:42 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Currently there's none and if there's just a summary text ($ notify-send text), the notification popup looks strange. Adding the default icon makes it look more consistent and not totally-out-of-place-command-line-notification.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationItem.qml 9e413f9 
> 
> Diff: https://git.reviewboard.kde.org/r/124151/diff/
> 
> 
> Testing
> -------
> 
> See screenshot
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/0d8a0ee1-af00-410c-80f1-79190f51daf5__notification-default-icon.png
> No icon notification
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/23/06c769be-b5fc-4360-9aac-6f3179601d92__notifications-layout1.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150623/a0488946/attachment.html>