Review Request 124151: Add a default icon to notifications popup

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124151/#review81676
-----------------------------------------------------------

Ship it!



applets/notifications/package/contents/ui/Notifications.qml (line 175)
<https://git.reviewboard.kde.org/r/124151/#comment56002>

    if (!…) { ?


- Kai Uwe Broulik


On Juni 22, 2015, 5:51 nachm., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124151/
> -----------------------------------------------------------
> 
> (Updated Juni 22, 2015, 5:51 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Currently there's none and if there's just a summary text ($ notify-send text), the notification popup looks strange. Adding the default icon makes it look more consistent and not totally-out-of-place-command-line-notification.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/Notifications.qml 13be7d4 
> 
> Diff: https://git.reviewboard.kde.org/r/124151/diff/
> 
> 
> Testing
> -------
> 
> See screenshot
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/0d8a0ee1-af00-410c-80f1-79190f51daf5__notification-default-icon.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150622/87ca4d6a/attachment.html>