Review Request 124151: Add a default icon to notifications popup

Martin Klapetek martin.klapetek at gmail.com
Mon Jun 22 17:51:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124151/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-workspace


Description
-------

Currently there's none and if there's just a summary text ($ notify-send text), the notification popup looks strange. Adding the default icon makes it look more consistent and not totally-out-of-place-command-line-notification.


Diffs
-----

  applets/notifications/package/contents/ui/Notifications.qml 13be7d4 

Diff: https://git.reviewboard.kde.org/r/124151/diff/


Testing
-------

See screenshot


File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/0d8a0ee1-af00-410c-80f1-79190f51daf5__notification-default-icon.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150622/7a9b2ad4/attachment.html>


More information about the Plasma-devel mailing list