Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

[Xuetian Weng]

> On June 15, 2015, 7:29 p.m., Lukáš Tinkl wrote:
> > A better option would be to call registerService() with QDBusConnectionInterface::ReplaceExistingService and DBusConnectionInterface::AllowReplacement
> 
> Martin Klapetek wrote:
>     It's the "attempt to replace it." part of it that I'm not entirely happy with. Plus we don't actually get to control all the servers and set "AllowReplacement" on them, so this might not be feasible in the end.

That's why I hate dbus activation when it comes to multiple desktop environment. There's only one service of the specific service that can be dbus-activated by dbus.
And BTW notify-osd does not set the allow replacement flag (checked their source code).


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124102/#review81489
-----------------------------------------------------------


On June 15, 2015, 2:30 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124102/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 2:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> We're getting lots of reports about notifications not being "closeable on click" or "not having any actions" or "not having Plasma theme". These all mostly come from users which have notify-osd package from Unity (ie. Ubuntu users installing plasma-desktop), but not only.
> 
> So this patch makes Plasma always be the Notification service provider if that option is enabled in the applet settings and/or if the applet is present somewhere (otherwise the dataengine is not loaded). On startup, it will get the PID of the current Notifications service, send SIGTERM to it and register its own service.
> 
> 
> Diffs
> -----
> 
>   dataengines/notifications/notificationsengine.h 7810787 
>   dataengines/notifications/notificationsengine.cpp c3bf373 
> 
> Diff: https://git.reviewboard.kde.org/r/124102/diff/
> 
> 
> Testing
> -------
> 
> Having notify-osd running, plasmashell starts up, notify-osd is terminated, Plasma notifications appear.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150617/f550c9cb/attachment.html>