Review Request 124108: [kcms/phonon] Don't overwrite audio profile entries with same priority

Bernie Innocenti bernie at codewiz.org
Wed Jun 17 17:30:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124108/
-----------------------------------------------------------

(Updated June 17, 2015, 5:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Harald Sitter.


Changes
-------

Submitted with commit 4b576cd02867672069c8077a43bb7caf442de8cc by Harald Sitter on behalf of Bernie Innocenti to branch Plasma/5.3.


Repository: plasma-desktop


Description
-------

My system has 3 HDMI ports, and HDMI2 is listed in pavucontrol,
but not in kcm_phonon. The reason was that HDMI2 and HDMI3 had the
same priority, and were overwriting each other in the cardInfo profiles
map. The fix consists in switching to a multimap.


Diffs
-----

  kcms/phonon/audiosetup.h dfb25bf8c111d72065a27bb91583026093f0598d 

Diff: https://git.reviewboard.kde.org/r/124108/diff/


Testing
-------

Manually tested with:
  QT_PLUGIN_PATH="$PWD:$QT_PLUGIN_PATH" kcmshell5 kcm_phonon


Thanks,

Bernie Innocenti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150617/3be1ec74/attachment.html>


More information about the Plasma-devel mailing list