Review Request 124108: [kcms/phonon] Don't overwrite audio profile entries with same priority

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124108/#review81509
-----------------------------------------------------------


looks good to me. I'll have to take a closer look at the code paths using it but at a glance it doesn't seem to concerning to switch to a multimap.

on schedule within the next 2 days.

- Harald Sitter


On June 16, 2015, 3:09 a.m., Bernie Innocenti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124108/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 3:09 a.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> My system has 3 HDMI ports, and HDMI2 is listed in pavucontrol,
> but not in kcm_phonon. The reason was that HDMI2 and HDMI3 had the
> same priority, and were overwriting each other in the cardInfo profiles
> map. The fix consists in switching to a multimap.
> 
> 
> Diffs
> -----
> 
>   kcms/phonon/audiosetup.h dfb25bf8c111d72065a27bb91583026093f0598d 
> 
> Diff: https://git.reviewboard.kde.org/r/124108/diff/
> 
> 
> Testing
> -------
> 
> Manually tested with:
>   QT_PLUGIN_PATH="$PWD:$QT_PLUGIN_PATH" kcmshell5 kcm_phonon
> 
> 
> Thanks,
> 
> Bernie Innocenti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150616/3d9d875c/attachment.html>