[PATCH] [kcms/phonon] Don't overwrite audio profile entries with same priority

Bernie Innocenti bernie at codewiz.org
Tue Jun 16 03:45:46 UTC 2015


On 15/06/15 22:01, Sebastian Kügler wrote:
> Easily: https://identity.kde.org/index.php?r=registration/index
 >
 > [...]
 >
> Ah, thanks for the note. I've updated the documentation about sending patches
> on Techbase.

Awesome, thanks for getting me started, I posted the review.

A few more suggestions to help streamline the new contributor onboarding 
process:

  - Add a note about reviewboard in HACKING, that's where I looked first

  - Move the "Reviewboard" paragraph near the top of 
https://techbase.kde.org/Contribute/Send_Patches

  - Add a link from https://techbase.kde.org/Development/Review_Board to 
https://techbase.kde.org/Contribute/Get_a_Contributor_Account#Apply_for_an_account

  - The paragraph "Who Can Apply For a KDE Contributor Account?" led me 
to believe that a casual contribution did not qualify for an account. 
Now I realize that I was confusing the basic identity with a full 
developer account, but it would be good to clarify it near the top of 
the page.

  - The Reviewboard page talks about a cli tool called "post-review", 
but I had to use "rbt post" on Fedora (the rpm is called RBTools, like 
on Suse).

-- 
  _ // Bernie Innocenti
  \X/  http://codewiz.org


More information about the Plasma-devel mailing list