Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124093/#review81459
-----------------------------------------------------------


Wouldn't that cause strange visual effects for the slideshow, when both images fade at the same time?

Did you try setting visible to false rather than opacity to zero? Really strange bug, we set opacity to zero and unset the source, so there's two things that should make it disappear :(

- Kai Uwe Broulik


On Juni 14, 2015, 9:15 vorm., Billy Lieurance wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124093/
> -----------------------------------------------------------
> 
> (Updated Juni 14, 2015, 9:15 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Moving the opacity change from a ScriptAction to a parallel OpacityAnimator.  That seems to cause a repaint in whatever weird environment happens to be the root of this bug.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml 23d23ff7003488d74ece0d70a1c68d129f282c75 
> 
> Diff: https://git.reviewboard.kde.org/r/124093/diff/
> 
> 
> Testing
> -------
> 
> See conversation on the bug page (https://bugs.kde.org/show_bug.cgi?id=345405).  This code should work identically to the current script, but for whatever reason it causes a repaint to be issued correctly whereas the other does not.
> 
> 
> Thanks,
> 
> Billy Lieurance
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150614/8c3eaed2/attachment-0001.html>