Review Request 124072: Refactor the Calendar grid computation a bit

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124072/
-----------------------------------------------------------

(Updated June 11, 2015, 7:36 p.m.)


Review request for Plasma.


Changes
-------

Couple minor refinements
* scale the month changing arrow same as the text and add borderWidth to their margin (so that they keep the same distance ratio regardless of the border width)
* make the day names row margin actually a spacing rather than boderWidth*2
* set the bottom margin of the grid to leftMargin so that all the margins are actually consistently big


Repository: plasma-framework


Description
-------

Makes the code a bit simpler & lighter and fixes the sometimes missing bottom line in calendar.

The grid is now equally padded from both sides (including the month name), so basically it's now
always aligned to the center and this also fixes the cases where there was a bigger padding on
one side than on the other.

The grid is now also anchored to the bottom so that the bottom margin can stay moreless consistent
with the side margins in different sizes.


Diffs (updated)
-----

  src/declarativeimports/calendar/qml/DaysCalendar.qml 5308708 
  src/declarativeimports/calendar/qml/MonthView.qml 86e37d8 

Diff: https://git.reviewboard.kde.org/r/124072/diff/


Testing
-------

Lots of 600x-zoom inspections and pixel counting. Tested both in Calendar applet and Digital Clock applet.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150611/79736b06/attachment.html>