Review Request 124047: Improve clock's tooltip layout

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/
-----------------------------------------------------------

(Updated June 10, 2015, 1:46 p.m.)


Review request for Plasma.


Changes
-------

With Kai's help I've managed to make it work with custom tooltip delegate. All in mklapetek/clockTooltip branch.


Bugs: 348078
    https://bugs.kde.org/show_bug.cgi?id=348078


Repository: plasma-workspace


Description
-------

In kde4 times, the layout of clock's tooltip was nicely arranged using a table. Now it's a bit of a mess so this brings back the table.

Also simplifies the timeForZone function which is used only for the tooltip.


Diffs (updated)
-----

  applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 
  applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e814056 

Diff: https://git.reviewboard.kde.org/r/124047/diff/


Testing
-------

See screenshots.


File Attachments
----------------

Before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/62594835-6bbb-436d-ba88-f39cb98b3033__clock-tooltip4.png
After
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/fc93cc02-881b-4bca-96a5-e0356baf4e61__clock-tooltip3.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150610/7a7a10a2/attachment.html>